Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exex oracle first iteration #22

Merged
merged 14 commits into from
Sep 27, 2024
Merged

Exex oracle first iteration #22

merged 14 commits into from
Sep 27, 2024

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Sep 8, 2024 •
edited
Loading

Depends on: #18
Closes #19

Offchain Data Feeder

  • Fetch data from an off-chain source.
  • Handle WS reconnections
  • Extend cli to support the data feeder args
  • Create an abstraction to easily manage different type of data source and plug it into the Oracle Future

Network

  • Enable the RLPx subprotocol messaging with the data structure of the off-chain data source.
  • Add an ECDSA signer.
  • Periodically sign and gossip the data to peers.
  • Track attestations
  • Tests

mattsse
mattsse requested changes Sep 10, 2024
View reviewed changes
oracle/src/offchain_data/binance/mod.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Contributor

mattsse commented Sep 10, 2024

the thing that's missing is signing and gossiping of the data,

this fetching part looks good to me

mattsse
mattsse requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty cool, some nits and suggestions.

love the tests. this is pretty easy to follow.

oracle/Cargo.toml Outdated Show resolved Hide resolved
oracle/Cargo.toml Outdated Show resolved Hide resolved
oracle/src/offchain_data/binance/feeder.rs Outdated Show resolved Hide resolved
oracle/src/network/proto/mod.rs Outdated Show resolved Hide resolved
oracle/src/main.rs Outdated Show resolved Hide resolved
oracle/src/network/gossip.rs Outdated Show resolved Hide resolved
oracle/src/network/mod.rs Outdated Show resolved Hide resolved
oracle/src/network/mod.rs Outdated Show resolved Hide resolved
@loocapro loocapro marked this pull request as ready for review September 26, 2024 18:57
@shekhirin shekhirin self-requested a review September 27, 2024 08:45
mattsse
mattsse requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is quite easy to follow now.

only have a few more nits

oracle/src/network/mod.rs Outdated Show resolved Hide resolved
oracle/src/network/proto/connection.rs Outdated Show resolved Hide resolved
oracle/src/network/proto/connection.rs Outdated Show resolved Hide resolved
oracle/src/network/proto/connection.rs Show resolved Hide resolved
mattsse
mattsse approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really cool, nice work

@mattsse mattsse merged commit 88ac91c into paradigmxyz:main Sep 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExEx Oracle - First iteration
2 participants
@loocapro @mattsse