added a basic test to run the oracle #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 16, 2024
This was referenced Oct 20, 2024
Merged
loocapro
force-pushed
the
e2e-tests
branch
2 times, most recently
from
5ba95b5
to
782a721
Compare
shekhirin
requested changes
Oct 29, 2024
shekhirin
requested changes
Oct 29, 2024
Comment on lines
+178
to
+185
| // expect signed data | ||
| let signed_ticker_1 = broadcast_stream_1.next().await.unwrap().unwrap(); | ||
| assert_eq!(signed_ticker_1.ticker.symbol, "BTCUSDT"); | ||
| assert_eq!(signed_ticker_1.signer, signer_1); | ||
|
|
||
| let signed_ticker_2 = broadcast_stream_2.next().await.unwrap().unwrap(); | ||
| assert_eq!(signed_ticker_2.ticker.symbol, "BTCUSDT"); | ||
| assert_eq!(signed_ticker_2.signer, signer_2); |
There was a problem hiding this comment.
so far this tests that both instances received an item from the stream, but it doesn't test if they actually exchange messages as peers after connecting. Can we do that as well?
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
shekhirin
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
#26 (comment) can be addressed in a separate PR, so LGTM as well! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an e2e test that:
Depends on: #33