lints: move top-level lints to [workspace.lints] manifest table (#5935)

paradigmxyz · Jan 4, 2024 · 9aa4409 · 9aa4409
1 parent 17b75dd
commit 9aa4409
Show file tree

Hide file tree

Showing 128 changed files with 211 additions and 145 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -66,6 +66,14 @@ default-members = ["bin/reth"]
 # https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html
 resolver = "2"
 
+[workspace.lints]
+rust.missing_debug_implementations = "warn"
+rust.missing_docs = "warn"
+rust.unreachable_pub = "warn"
+rustdoc.all = "warn"
+rust.unused_must_use = "deny"
+rust.rust_2018_idioms = "deny"
+
 [workspace.package]
 version = "0.1.0-alpha.13"
 edition = "2021"

diff --git a/bin/reth/Cargo.toml b/bin/reth/Cargo.toml
@@ -9,6 +9,9 @@ repository.workspace = true
 description = "Reth node implementation"
 default-run = "reth"
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

diff --git a/bin/reth/build.rs b/bin/reth/build.rs
@@ -1,3 +1,5 @@
+#![allow(missing_docs)]
+
 use std::error::Error;
 use vergen::EmitBuilder;
 

diff --git a/bin/reth/src/lib.rs b/bin/reth/src/lib.rs
@@ -24,8 +24,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![allow(missing_debug_implementations)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod args;

diff --git a/bin/reth/src/main.rs b/bin/reth/src/main.rs
@@ -1,4 +1,5 @@
 // We use jemalloc for performance reasons
+#![allow(missing_docs)]
 #[cfg(all(feature = "jemalloc", unix))]
 #[global_allocator]
 static ALLOC: jemallocator::Jemalloc = jemallocator::Jemalloc;

diff --git a/bin/reth/src/optimism.rs b/bin/reth/src/optimism.rs
@@ -1,3 +1,4 @@
+#![allow(missing_docs, rustdoc::missing_crate_level_docs)]
 // We use jemalloc for performance reasons
 #[cfg(all(feature = "jemalloc", unix))]
 #[global_allocator]

diff --git a/crates/blockchain-tree/Cargo.toml b/crates/blockchain-tree/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

diff --git a/crates/blockchain-tree/src/lib.rs b/crates/blockchain-tree/src/lib.rs
@@ -15,8 +15,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod blockchain_tree;

diff --git a/crates/config/Cargo.toml b/crates/config/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-network.workspace = true

diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod config;

diff --git a/crates/consensus/auto-seal/Cargo.toml b/crates/consensus/auto-seal/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "A consensus impl for local testing purposes"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-beacon-consensus.workspace = true

diff --git a/crates/consensus/auto-seal/src/lib.rs b/crates/consensus/auto-seal/src/lib.rs
@@ -12,8 +12,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use reth_beacon_consensus::BeaconEngineMessage;
@@ -42,7 +40,7 @@ use std::{
     time::{SystemTime, UNIX_EPOCH},
 };
 use tokio::sync::{mpsc::UnboundedSender, RwLock, RwLockReadGuard, RwLockWriteGuard};
-use tracing::{trace, warn};
+use tracing::trace;
 
 mod client;
 mod mode;

diff --git a/crates/consensus/auto-seal/tests/it/auto_mine.rs b/crates/consensus/auto-seal/tests/it/auto_mine.rs
@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! auto-mine consensus integration test
 
 use clap::Parser;

diff --git a/crates/consensus/beacon/Cargo.toml b/crates/consensus/beacon/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-beacon-consensus-core.workspace = true

diff --git a/crates/consensus/beacon/src/lib.rs b/crates/consensus/beacon/src/lib.rs
@@ -5,14 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub use reth_beacon_consensus_core::BeaconConsensus;

diff --git a/crates/consensus/common/Cargo.toml b/crates/consensus/common/Cargo.toml
@@ -7,8 +7,11 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
-# reth 
+# reth
 reth-primitives.workspace = true
 reth-interfaces.workspace = true
 reth-provider.workspace = true

diff --git a/crates/consensus/common/src/lib.rs b/crates/consensus/common/src/lib.rs
@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Collection of consensus validation methods.

diff --git a/crates/ethereum-forks/Cargo.toml b/crates/ethereum-forks/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Ethereum fork types used in reth."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-codecs.workspace = true

diff --git a/crates/ethereum-forks/src/lib.rs b/crates/ethereum-forks/src/lib.rs
@@ -11,8 +11,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms, unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod forkid;

diff --git a/crates/interfaces/Cargo.toml b/crates/interfaces/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 reth-primitives.workspace = true
 reth-nippy-jar.workspace = true

diff --git a/crates/interfaces/src/lib.rs b/crates/interfaces/src/lib.rs
@@ -9,14 +9,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![warn(unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Consensus traits.

diff --git a/crates/metrics/Cargo.toml b/crates/metrics/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "reth metrics utilities"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-metrics-derive.workspace = true

diff --git a/crates/metrics/metrics-derive/Cargo.toml b/crates/metrics/metrics-derive/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 proc-macro = true
 

diff --git a/crates/metrics/metrics-derive/src/lib.rs b/crates/metrics/metrics-derive/src/lib.rs
@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use proc_macro::TokenStream;

diff --git a/crates/metrics/src/lib.rs b/crates/metrics/src/lib.rs
@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Metrics derive macro.

diff --git a/crates/net/common/Cargo.toml b/crates/net/common/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Types shared across network code"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

diff --git a/crates/net/common/src/lib.rs b/crates/net/common/src/lib.rs
@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod ban_list;

diff --git a/crates/net/discv4/Cargo.toml b/crates/net/discv4/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Ethereum network discovery"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

diff --git a/crates/net/discv4/src/lib.rs b/crates/net/discv4/src/lib.rs
@@ -21,8 +21,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms, unreachable_pub, unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use crate::{
@@ -64,7 +62,7 @@ use tokio::{
     time::Interval,
 };
 use tokio_stream::{wrappers::ReceiverStream, Stream, StreamExt};
-use tracing::{debug, trace, warn};
+use tracing::{debug, trace};
 
 pub mod error;
 pub mod proto;

diff --git a/crates/net/dns/Cargo.toml b/crates/net/dns/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Support for EIP-1459 Node Discovery via DNS"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

diff --git a/crates/net/dns/src/lib.rs b/crates/net/dns/src/lib.rs
@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub use crate::resolver::{DnsResolver, MapResolver, Resolver};
@@ -47,7 +45,7 @@ use tokio_stream::{
     wrappers::{ReceiverStream, UnboundedReceiverStream},
     Stream, StreamExt,
 };
-use tracing::{debug, trace, warn};
+use tracing::{debug, trace};
 
 mod config;
 mod error;

diff --git a/crates/net/downloaders/Cargo.toml b/crates/net/downloaders/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Implementations of various block downloaders"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-interfaces.workspace = true

diff --git a/crates/net/downloaders/src/lib.rs b/crates/net/downloaders/src/lib.rs
@@ -9,8 +9,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// The collection of algorithms for downloading block bodies.

diff --git a/crates/net/ecies/Cargo.toml b/crates/net/ecies/Cargo.toml
@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 reth-primitives.workspace = true
 reth-net-common.workspace = true

diff --git a/crates/net/ecies/src/lib.rs b/crates/net/ecies/src/lib.rs
@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod algorithm;

diff --git a/crates/net/eth-wire/Cargo.toml b/crates/net/eth-wire/Cargo.toml
@@ -8,6 +8,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-codecs.workspace = true

diff --git a/crates/net/eth-wire/src/lib.rs b/crates/net/eth-wire/src/lib.rs
@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod builder;

diff --git a/crates/net/nat/Cargo.toml b/crates/net/nat/Cargo.toml
@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Helpers for working around NAT"
 
+[lints]
+workspace = true
+
 [dependencies]
 
 # nat