Skip to content

Commit

Permalink
chore: remove outdated TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
Rjected committed Sep 6, 2023
1 parent 422d930 commit db5bfb2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions crates/payload/builder/src/payload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ impl From<BuiltPayload> for ExecutionPayloadV1 {
}

// V2 engine_getPayloadV2 response
// TODO(rjected): we could improve this by wrapping envelope / payload types by version, so we can
// have explicitly versioned return types for getPayload. Then BuiltPayload could essentially be a
// builder for those types, and it would not be possible to e.g. return cancun fields for a
// pre-cancun endpoint.
impl From<BuiltPayload> for ExecutionPayloadEnvelopeV2 {
fn from(value: BuiltPayload) -> Self {
let BuiltPayload { block, fees, .. } = value;
Expand Down
1 change: 0 additions & 1 deletion crates/rpc/rpc-engine-api/src/engine_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ where

let cancun_fields = CancunPayloadFields { versioned_hashes, parent_beacon_block_root };

// TODO: validate versioned hashes and figure out what to do with parent_beacon_block_root
Ok(self.inner.beacon_consensus.new_payload(payload, Some(cancun_fields)).await?)
}

Expand Down

0 comments on commit db5bfb2

Please sign in to comment.