unify block_range and tx_range api on segment header

paradigmxyz · Jan 17, 2024 · dd749fc · dd749fc
1 parent 0bc9b91
commit dd749fc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/crates/primitives/src/snapshot/segment.rs b/crates/primitives/src/snapshot/segment.rs
@@ -158,7 +158,7 @@ impl SegmentHeader {
 
     /// Returns the block range.
     pub fn block_range(&self) -> RangeInclusive<BlockNumber> {
-        &self.block_range
+        self.block_range.clone()
     }
 
     /// Returns the transaction range.

diff --git a/crates/storage/db/src/snapshot/mod.rs b/crates/storage/db/src/snapshot/mod.rs
@@ -40,8 +40,7 @@ pub fn iter_snapshots(path: impl AsRef<Path>) -> Result<SortedSnapshots, NippyJa
             {
                 let jar = NippyJar::<SegmentHeader>::load(&entry.path())?;
 
-                let ranges =
-                    (jar.user_header().block_range().clone(), jar.user_header().tx_range());
+                let ranges = (jar.user_header().block_range(), jar.user_header().tx_range());
 
                 match static_files.entry(segment) {
                     Entry::Occupied(mut entry) => {

diff --git a/crates/storage/provider/src/providers/snapshot/manager.rs b/crates/storage/provider/src/providers/snapshot/manager.rs
@@ -255,7 +255,7 @@ impl SnapshotProvider {
 
                     // Current block range has the same block start as `fixed_range``, but block end
                     // might be different if we are still filling this static file.
-                    let current_block_range = jar.user_header().block_range().clone();
+                    let current_block_range = jar.user_header().block_range();
 
                     // Considering that `update_index` is called when we either append/truncate, we
                     // are sure that we are handling the latest data points.