Skip to content

Commit

Permalink
temporary/ci: comment fsync
Browse files Browse the repository at this point in the history
  • Loading branch information
joshieDo committed Feb 5, 2024
1 parent 0210eb9 commit f6a8b5e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions crates/storage/nippy-jar/src/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl<'a, H: NippyJarHeader> NippyJarWriter<'a, H> {

// First byte of the offset file is the size of one offset in bytes
offsets_file.write_all(&[OFFSET_SIZE_BYTES as u8])?;
offsets_file.sync_all()?;
// offsets_file.sync_all()?;
offsets_file.seek(SeekFrom::End(0))?;

Ok((data_file, offsets_file, is_created))
Expand Down Expand Up @@ -383,8 +383,8 @@ impl<'a, H: NippyJarHeader> NippyJarWriter<'a, H> {
}
}

self.offsets_file.sync_all()?;
self.data_file.sync_all()?;
// self.offsets_file.sync_all()?;
// self.data_file.sync_all()?;

self.offsets_file.seek(SeekFrom::End(0))?;
self.data_file.seek(SeekFrom::End(0))?;
Expand All @@ -411,7 +411,7 @@ impl<'a, H: NippyJarHeader> NippyJarWriter<'a, H> {

/// Commits configuration and offsets to disk. It drains the internal offset list.
pub fn commit(&mut self) -> Result<(), NippyJarError> {
self.data_file.sync_all()?;
// self.data_file.sync_all()?;

self.commit_offsets()?;

Expand Down Expand Up @@ -446,7 +446,7 @@ impl<'a, H: NippyJarHeader> NippyJarWriter<'a, H> {
}
self.offsets_file.write_all(&offset.to_le_bytes())?;
}
self.offsets_file.sync_all()?;
// self.offsets_file.sync_all()?;

Ok(())
}
Expand Down

0 comments on commit f6a8b5e

Please sign in to comment.