rename hook action, add todo item

paradigmxyz · Sep 19, 2023 · fcb3608 · fcb3608
1 parent 33123ae
commit fcb3608
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/crates/consensus/beacon/src/engine/hooks/mod.rs b/crates/consensus/beacon/src/engine/hooks/mod.rs
@@ -88,9 +88,8 @@ impl EngineHookEvent {
 pub enum EngineHookAction {
     /// Notify about a [SyncState] update.
     UpdateSyncState(SyncState),
-    /// Read the last relevant canonical hashes from the database and update the block indices of
-    /// the blockchain tree.
-    RestoreCanonicalHashes,
+    /// Connect blocks buffered during the hook execution to canonical hashes.
+    ConnectBufferedBlocks,
 }
 
 /// An error returned by [hook][`EngineHook`].

diff --git a/crates/consensus/beacon/src/engine/hooks/prune.rs b/crates/consensus/beacon/src/engine/hooks/prune.rs
@@ -74,7 +74,7 @@ impl<DB: Database + 'static> PruneHook<DB> {
         };
 
         let action = if matches!(event, EngineHookEvent::Finished(Ok(_))) {
-            Some(EngineHookAction::RestoreCanonicalHashes)
+            Some(EngineHookAction::ConnectBufferedBlocks)
         } else {
             None
         };

diff --git a/crates/consensus/beacon/src/engine/mod.rs b/crates/consensus/beacon/src/engine/mod.rs
@@ -1686,7 +1686,9 @@ where
             EngineHookAction::UpdateSyncState(state) => {
                 self.sync_state_updater.update_sync_state(state)
             }
-            EngineHookAction::RestoreCanonicalHashes => {
+            // TODO(alexey): always connect buffered blocks if hook had the
+            //  `EngineHookDBAccessLevel::ReadWrite`
+            EngineHookAction::ConnectBufferedBlocks => {
                 if let Err(error) = self.blockchain.connect_buffered_blocks_to_canonical_hashes() {
                     error!(target: "consensus::engine", ?error, "Error restoring blockchain tree state");
                     return Err(error.into())