Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move reth-db-api::encode and decode to reth-db-serialization #10821

Closed
nkysg opened this issue Sep 11, 2024 · 2 comments · May be fixed by #10822
Closed

move reth-db-api::encode and decode to reth-db-serialization #10821

nkysg opened this issue Sep 11, 2024 · 2 comments · May be fixed by #10822
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity

Comments

@nkysg
Copy link
Contributor

nkysg commented Sep 11, 2024 •
edited
Loading

Describe the feature

ref #10081.

If we move reth-db-api::encode and decode to reth-db-serialization, then StorageShardedKey can move to reth-db-models.

Additional context

No response
@nkysg nkysg added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 11, 2024
@nkysg nkysg mentioned this issue Sep 11, 2024
Open
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database and removed C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 12, 2024
@nkysg nkysg changed the title move reth-db-api::encode and decode to reth-codecs move reth-db-api::encode and decode to reth-db-serialization Sep 18, 2024
@nkysg nkysg mentioned this issue Sep 18, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(db): move reth-db-api::encode and decode to reth-db-serialization nkysg/reth
2 participants
@nkysg @emhane