Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract db-api::models to a standalone crate #10081

Closed
mattsse opened this issue Aug 5, 2024 · 2 comments
Closed

Extract db-api::models to a standalone crate #10081

mattsse opened this issue Aug 5, 2024 · 2 comments
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 5, 2024

Describe the feature

we're using some types declared in db-api::models

pub mod accounts;
pub mod blocks;
pub mod client_version;
pub mod integer_list;
pub mod sharded_key;
pub mod storage_sharded_key;
pub use accounts::*;
pub use blocks::*;
pub use client_version::ClientVersion;
pub use sharded_key::ShardedKey;

in other parts of the codebase such as storage-api

it'd be nice if this were possible without depending on db-api, e.g:

reth-db-api.workspace = true

use reth_db_api::models::AccountBeforeTx;

TODO

  • extract models to db-types or db-models and update deps, db-api would then depend on -types

Additional context

No response

@nkysg
Copy link
Contributor

nkysg commented Sep 25, 2024

I think I can continue next.

@shekhirin shekhirin removed their assignment Oct 17, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 24, 2024

marking this as completed for now

@mattsse mattsse closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

No branches or pull requests

5 participants