-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract db-api::models to a standalone crate #10081
Comments
mattsse
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
labels
Aug 5, 2024
emhane
added
C-debt
Refactor of code section that is hard to understand or maintain
A-db
Related to the database
and removed
C-enhancement
New feature or request
labels
Sep 12, 2024
This was referenced Sep 18, 2024
I think I can continue next. |
marking this as completed for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
we're using some types declared in db-api::models
reth/crates/storage/db-api/src/models/mod.rs
Lines 14 to 24 in 6c76845
in other parts of the codebase such as storage-api
it'd be nice if this were possible without depending on db-api, e.g:
reth/crates/storage/storage-api/Cargo.toml
Line 18 in 6c76845
reth/crates/storage/storage-api/src/account.rs
Line 2 in 6c76845
TODO
db-types
ordb-models
and update deps, db-api would then depend on -typesAdditional context
No response
The text was updated successfully, but these errors were encountered: