Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): models crate #10314

Merged
merged 5 commits into from
Aug 17, 2024
Merged

feat(db): models crate #10314

merged 5 commits into from
Aug 17, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 15, 2024

Towards #10081.

This PR moves only two types and it's enough for making reth-storage-api independent of reth-db-api.

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database labels Aug 15, 2024
@shekhirin shekhirin marked this pull request as ready for review August 15, 2024 02:41
@mvares
Copy link
Contributor

mvares commented Aug 15, 2024

:shipit:

@rkrasiuk
Copy link
Member

@shekhirin merge?

@shekhirin shekhirin requested review from onbjerg and removed request for onbjerg August 17, 2024 17:25
@shekhirin shekhirin added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit 6bf3ca3 Aug 17, 2024
37 checks passed
@shekhirin shekhirin deleted the alexey/db-models branch August 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants