Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FlatCallTracer #10991

Closed
mattsse opened this issue Sep 18, 2024 · 2 comments · Fixed by #11114
Closed

Add support for FlatCallTracer #10991

mattsse opened this issue Sep 18, 2024 · 2 comments · Fixed by #11114
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 18, 2024

Describe the feature

ref #201 might require some helper for TracingConfig

blocked by #10989

we now have a new variant:

GethDebugBuiltInTracerType::FlatCallTracer => {
return Err(
EthApiError::Unsupported("Flatcall tracer is not supported yet").into()
)
}

that behaves exactly as the parity tracer, so we can reuse that impl:

/// Returns all traces for the given transaction hash
pub async fn trace_transaction(
&self,
hash: B256,
) -> Result<Option<Vec<LocalizedTransactionTrace>>, Eth::Error> {
self.inner
.eth_api
.spawn_trace_transaction_in_block(
hash,
TracingInspectorConfig::default_parity(),
move |tx_info, inspector, _, _| {
let traces =
inspector.into_parity_builder().into_localized_transaction_traces(tx_info);
Ok(traces)
},
)
.await
}

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Sep 18, 2024
@0xkrane
Copy link
Contributor

0xkrane commented Sep 18, 2024

can take this

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 18, 2024

unblocked now

mattsse added a commit to paradigmxyz/revm-inspectors that referenced this issue Sep 23, 2024
For use and uniformity wrt
paradigmxyz/reth#10991

Simple tests included

I could do the PR without this but seems correct to maintain uniformity
instead of modifying the `TracingInspector` in ad hoc ways

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 24, 2024
lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this issue Oct 8, 2024
For use and uniformity wrt
paradigmxyz/reth#10991

Simple tests included

I could do the PR without this but seems correct to maintain uniformity
instead of modifying the `TracingInspector` in ad hoc ways

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants