Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reth rpc-types import audit #11067

Closed
mattsse opened this issue Sep 20, 2024 · 1 comment
Closed

reth rpc-types import audit #11067

mattsse opened this issue Sep 20, 2024 · 1 comment
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 20, 2024

Describe the feature

currently the rpc-types crate is just a bunch of re-exports and after #7490 this will even be just re-exports

this crate is pretty beefy and we should discourage importing it, instead reth crates should use the alloy crates directly either via alloy-rpc-types with the necessary features or if only one set of types is required, with the corresponding crate, alloy-rpc-types-eth for example.

TODO

  • Incrementally move away from reth-rpc-types in other reth crate (reth-rpc-types -> alloy-rpc-types+required features)
  • then eventually deprecate reth-rpc-types

this should be done on multiple prs, similar to #10749

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Sep 20, 2024
@greged93 greged93 mentioned this issue Sep 20, 2024
Merged
This was referenced Sep 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@greged93 greged93 mentioned this issue Sep 21, 2024
Merged
@tcoratger tcoratger mentioned this issue Sep 21, 2024
Merged
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-dependencies Pull requests or issues that are about dependencies and removed C-enhancement New feature or request labels Sep 22, 2024
@tcoratger tcoratger mentioned this issue Sep 22, 2024
Merged
This was referenced Sep 23, 2024
Merged
Merged
@mattsse
Copy link
Collaborator Author

mattsse commented Sep 25, 2024

marking as complete for now

@mattsse mattsse closed this as completed Sep 25, 2024
@mattsse mattsse mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @emhane