Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc-types: rm alloy-rpc-types-engine reexport #11206

Merged
merged 6 commits into from
Sep 25, 2024
Merged

rpc-types: rm alloy-rpc-types-engine reexport #11206

merged 6 commits into from
Sep 25, 2024

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Sep 25, 2024 •
edited
Loading

Should close #11198

@mattsse
Copy link
Collaborator

mattsse commented Sep 25, 2024

oh I think this task was technically still part of #11067

and I opened and assigned #11198

so this actually closes #11198

FYI @jenpaff

@mattsse mattsse added the A-rpc Related to the RPC implementation label Sep 25, 2024
@mattsse mattsse added this pull request to the merge queue Sep 25, 2024
Merged via the queue into paradigmxyz:main with commit c00516c Sep 25, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove engine api re-export from rpc-types crate
2 participants
@tcoratger @mattsse