primitives: use alloy Sealed<Header> instead of SealedHeader

[tcoratger]

Describe the feature

The current codebase uses the SealedHeader struct:

reth/crates/primitives-traits/src/header/sealed.rs

Lines 13 to 24 in 7529d36

	/// A [`Header`] that is sealed at a precalculated hash, use [`SealedHeader::unseal()`] if you want
	/// to modify header.
	#[derive(Debug, Clone, PartialEq, Eq, Hash, AsRef, Deref, Serialize, Deserialize, Compact)]
	#[add_arbitrary_tests(rlp, compact)]
	pub struct SealedHeader {
	/// Locked Header hash.
	hash: BlockHash,
	/// Locked Header fields.
	#[as_ref]
	#[deref]
	header: Header,
	}

This is redundant with Alloy's Sealed<Header> type:

https://github.com/alloy-rs/core/blob/4b823f7977fcdc181a0bd04ba1b2c51f7a29b4e2/crates/primitives/src/sealed.rs#L3-L14

After the merge of #10691, we have multiple unnecessary conversions between Sealed<Header> and SealedHeader when sealing headers, as we now rely on the Alloy consensus Header type.

Task

• Remove SealedHeader from the codebase.
• Re-export and use Sealed<Header> from Alloy consistently.

Related #10691 (comment)

Additional context

No response

[greged93]

hey I'm down to work on this

[emhane]

did you get around to starting on this @greged93 ?

[greged93]

@emhane I started and got caught in something else, let me jump back on it.
I think there were a couple of issues to fix regarding derives on Sealed (arbitrary, rlp encode, default, compact,...). Is it ok to add all these derives in Alloy?

[emhane]

@greged93 see #11442 (comment)

[greged93]

@emhane this solves it for compact but we still have the same issue for Default, Encodable, Decodable and Arbitrary. Ok to add all these to alloy? Or use a new type ?

[emhane]

thanks for the investigation @greged93 . blocked by alloy-rs/core#754, alloy-rs/core#755 and alloy-rs/core#762.

[mattsse]

there's no reason this type should even have rlp support.

the current arbitrary derive is also problematic as highlighted here alloy-rs/core#762

[greged93]

I'll check where it is needed but currently Encodable and Decodable are implemented on SealedHeader.

[mattsse]

none of this should be there because using rlp on a sealed type is never used in any protocol

[greged93]

Ok! Will wait on arbitrary and remove rlp then!

[greged93]

@mattsse what should we do for Sealed<Header> then? If you want to keep the rlp implementation then we can add it to Alloy or add a newtype

[emhane]

main reason we want this is to use the alloy Sealable trait

https://github.com/alloy-rs/core/blob/172aa98d4c0d20b0f1fe1812a8d378d7005a4011/crates/primitives/src/sealed.rs#L90-L99

rlp traits will have to be implemented on a wrapper type in reth @greged93

[greged93]

noted! just waiting on arbitrary which should be in alloy-primitives 0.8.6 then

[github-actions]

This issue is stale because it has been open for 21 days with no activity.