Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Default for Sealed<T> #755

Merged
merged 3 commits into from
Oct 5, 2024
Merged

feat: add Default for Sealed<T> #755

merged 3 commits into from
Oct 5, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 4, 2024

Motivation

Default is required trait bound for reth integration of Sealed<T>. Ref paradigmxyz/reth#11123.

Solution

Derives Default for Sealed<T>.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Refactor of code section that is hard to understand or maintain label Oct 4, 2024
@emhane emhane mentioned this pull request Oct 4, 2024
Open
mattsse
mattsse requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also problematic, we can only safely do this if we seal in the manual default impl

@emhane
Copy link
Member Author

emhane commented Oct 4, 2024

this is also problematic, we can only safely do this if we seal in the manual default impl

same here, pls open issue in reth to manual impl Default for all types that use SealedBlock

@emhane emhane requested a review from mattsse October 4, 2024 17:34
@mattsse mattsse changed the title Derive Default for Sealed<T> feat: add Default for Sealed<T> Oct 5, 2024
@mattsse mattsse merged commit deae8c6 into main Oct 5, 2024
29 checks passed
@mattsse mattsse deleted the emhane/default-sealed branch October 5, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse