Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AnyNetwork with alloy_network::Ethereum in EthApiTypes impl for EthApi #11165

Closed
1 task done
emhane opened this issue Sep 24, 2024 · 2 comments
Closed
1 task done

Replace AnyNetwork with alloy_network::Ethereum in EthApiTypes impl for EthApi #11165

emhane opened this issue Sep 24, 2024 · 2 comments
Labels
A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@emhane
Copy link
Member

emhane commented Sep 24, 2024 •
edited
Loading

Describe the feature

Replace AnyNetwork with alloy_network::Ethereum

reth/crates/rpc/rpc/src/eth/core.rs

Lines 127 to 135 in f606b70

impl<Provider, Pool, Network, EvmConfig> EthApiTypes for EthApi<Provider, Pool, Network, EvmConfig>
where
Self: Send + Sync,
{
type Error = EthApiError;
// todo: replace with alloy_network::Ethereum
type NetworkTypes = AnyNetwork;
type TransactionCompat = EthTxBuilder;
}

May encounter some blockers, in that case please mark the pr and issue with label S-blocked and open an issue for task that will unblock it.

Additional context

No response

Tasks
Preview Give feedback
  1. rpc: modify ReceiptBuilder build method #11219
    A-rpc C-debt D-good-first-issue
@emhane emhane added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation labels Sep 24, 2024
@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started and removed D-good-first-issue Nice and easy! A great choice to get started labels Sep 24, 2024
This was referenced Sep 25, 2024
Closed
Closed
@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started C-tracking-issue An issue that collects information about a broad development initiative and removed D-good-first-issue Nice and easy! A great choice to get started labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 18, 2024
@emhane emhane added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 18, 2024
@emhane
Copy link
Member Author

emhane commented Nov 19, 2024

closed by #12280

@emhane emhane closed this as completed Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: replace NetworkTypes AT by Ethereum for EthApi tcoratger/reth
1 participant
@emhane