Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove AnyNetwork usage #12280

Merged
merged 2 commits into from
Nov 2, 2024
Merged

feat: remove AnyNetwork usage #12280

merged 2 commits into from
Nov 2, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 2, 2024

Migrates EthApi to using Ethereum network instead of AnyNetwork

This would allow to make #12215 cleaner as with alloy-rs/alloy#1460 AnyNetwork rpc transaction structure is a bit different

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hell yeah

@mattsse mattsse added the A-rpc Related to the RPC implementation label Nov 2, 2024
@mattsse mattsse added this pull request to the merge queue Nov 2, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Nov 2, 2024
@mattsse
Copy link
Collaborator

mattsse commented Nov 2, 2024

good to merge or should we hold off until #12215 is ready?

@klkvr
Copy link
Collaborator Author

klkvr commented Nov 2, 2024

good to merge or should we hold off until #12215 is ready?

good to merge, it should make #12215 less painful

@mattsse mattsse added this pull request to the merge queue Nov 2, 2024
Merged via the queue into main with commit adff5a9 Nov 2, 2024
41 checks passed
@mattsse mattsse deleted the klkvr/use-eth-tx branch November 2, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants