Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Serialize bincode-compatible implementation for Chain #11389

Closed
shekhirin opened this issue Oct 1, 2024 · 1 comment · Fixed by #11538
Closed

Manual Serialize bincode-compatible implementation for Chain #11389

shekhirin opened this issue Oct 1, 2024 · 1 comment · Fixed by #11538
Assignees
@greged93
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator 

          we could get rid of this by manually impl serialize but for now this is okay

Originally posted by @mattsse in #11331 (comment)
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain labels Oct 4, 2024
@greged93
Copy link
Contributor

greged93 commented Oct 7, 2024

hey @shekhirin can I work on this?

@greged93 greged93 mentioned this issue Oct 7, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greged93 greged93

Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: chain manual serialisation implementation greged93/reth
3 participants
@shekhirin @mattsse @greged93