feat(exex, primitives): serde bincode compatibility #11331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/exex-serde-bincode-compat
branch
from
e7dfa77
to
29237fd
Compare
shekhirin
force-pushed
the
alexey/exex-serde-bincode-compat
branch
from
407ce0e
to
5cd1508
Compare
shekhirin
force-pushed
the
alexey/exex-serde-bincode-compat
branch
from
5cd1508
to
c2062c6
Compare
shekhirin
force-pushed
the
alexey/exex-serde-bincode-compat
branch
from
7b1d402
to
3e27793
Compare
|
fails with optimism feature, fixing ❯ SEED=4 cargo t --quiet -p reth-primitives --features serde-bincode-compat,optimism block_body_bincode
running 1 test
block::serde_bincode_compat::tests::test_block_body_bincode_roundtrip --- FAILED
failures:
---- block::serde_bincode_compat::tests::test_block_body_bincode_roundtrip stdout ----
thread 'block::serde_bincode_compat::tests::test_block_body_bincode_roundtrip' panicked at crates/primitives/src/block.rs:1086:64:
called `Result::unwrap()` on an `Err` value: InvalidTagEncoding(32)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
block::serde_bincode_compat::tests::test_block_body_bincode_roundtrip
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 99 filtered out; finished in 0.09s
error: test failed, to rerun pass `-p reth-primitives --lib`
❯ SEED=4 cargo t --quiet -p reth-primitives --features serde-bincode-compat block_body_bincode
running 1 test
.
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 96 filtered out; finished in 0.10s |
|
fixed by alloy-rs/op-alloy#131 ❯ cargo t -p reth-primitives --features serde-bincode-compat,optimism --no-run
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.34s
Executable unittests src/lib.rs (target/debug/deps/reth_primitives-5d9f9518ba4cbf81)
❯ hyperfine -r 100 -- "./target/debug/deps/reth_primitives-5d9f9518ba4cbf81 block_body_bincode"
Benchmark 1: ./target/debug/deps/reth_primitives-5d9f9518ba4cbf81 block_body_bincode
Time (mean ± σ): 63.6 ms ± 6.9 ms [User: 59.5 ms, System: 1.6 ms]
Range (min … max): 59.1 ms … 113.2 ms 100 runs |
shekhirin
requested review from
joshieDo,
Rjected,
onbjerg,
rakita,
mattsse and
gakonst
as code owners
mattsse
approved these changes
Sep 30, 2024
Comment on lines
+766
to
+770
| blocks: value | ||
| .blocks | ||
| .iter() | ||
| .map(|(block_number, block)| (*block_number, block.into())) | ||
| .collect(), |
There was a problem hiding this comment.
we could get rid of this by manually impl serialize but for now this is okay
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11170
Blocked by alloy-rs/op-alloy#131