Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransactionSignedNoHash type #12471

Closed
Tracked by #12575
mattsse opened this issue Nov 12, 2024 · 1 comment · Fixed by #12596
Closed
Tracked by #12575

Remove TransactionSignedNoHash type #12471

mattsse opened this issue Nov 12, 2024 · 1 comment · Fixed by #12596
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 12, 2024

Describe the feature

this type is just

pub struct TransactionSigned {

without the hash. the reason this exists is that for some operations we don't need to fetch the hash from disk.

but we can solve this by converting the hash field into a LazyLock<Hash> instead, which is then initialized with the hash if missing.

This should be solved in multiple steps:

  1. convert hash to LazyLock
  2. convert all provider functions to TransactionSigned (from TransactionSignedNoHash)
  3. remove TransactionSignedNoHash

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 12, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Nov 12, 2024
@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants