Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_createAccessList always reports max fee per gas less than block base fee #1783

Closed
1 task done
Tracked by #1579
Rjected opened this issue Mar 15, 2023 · 2 comments · Fixed by #2028 or #2041
Closed
1 task done
Tracked by #1579

eth_createAccessList always reports max fee per gas less than block base fee #1783

Rjected opened this issue Mar 15, 2023 · 2 comments · Fixed by #2028 or #2041
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong

Comments

@Rjected
Copy link
Member

Rjected commented Mar 15, 2023

Describe the bug

The rpc-compat test eth_createAccessList fails with the following logs:

>>  {"jsonrpc":"2.0","id":1,"method":"eth_createAccessList","params":[{"from":"0x658bdf435d810c91414ec09147daa6db62406379","to":"0xbb00000000000000000000000000000000000000"},"latest"]}
<<  {"jsonrpc":"2.0","error":{"code":-32003,"message":"max fee per gas less than block base fee"},"id":1}
response differs from expected:
 {
-  "error": {
-    "code": -32003,
-    "message": "max fee per gas less than block base fee"
-  },
   "id": 1,
   "jsonrpc": "2.0"
+  "result": {
+    "accessList": [
+      : {
+        "address": "0xbb00000000000000000000000000000000000000",
+        "storageKeys": [
+          : "0x0000000000000000000000000000000000000000000000000000000000000001",
+          : "0x0000000000000000000000000000000000000000000000000000000000000003"
+        ]
+      }
+    ],
+    "gasUsed": "0x6b0e"
+  }
 }

>>  {"jsonrpc":"2.0","id":1,"method":"eth_createAccessList","params":[{"from":"0x658bdf435d810c91414ec09147daa6db62406379","to":"0xaa00000000000000000000000000000000000000"},"latest"]}
<<  {"jsonrpc":"2.0","error":{"code":-32003,"message":"max fee per gas less than block base fee"},"id":1}
response differs from expected:
 {
-  "error": {
-    "code": -32003,
-    "message": "max fee per gas less than block base fee"
-  },
   "id": 1,
   "jsonrpc": "2.0"
+  "result": {
+    "accessList": [
+    ],
+    "gasUsed": "0x520b"
+  }
 }

>>  {"jsonrpc":"2.0","id":1,"method":"eth_createAccessList","params":[{"from":"0x658bdf435d810c91414ec09147daa6db62406379","to":"0x0100000000000000000000000000000000000000"},"latest"]}
<<  {"jsonrpc":"2.0","error":{"code":-32003,"message":"max fee per gas less than block base fee"},"id":1}
response differs from expected:
 {
-  "error": {
-    "code": -32003,
-    "message": "max fee per gas less than block base fee"
-  },
   "id": 1,
   "jsonrpc": "2.0"
+  "result": {
+    "accessList": [
+    ],
+    "gasUsed": "0x5208"
+  }
 }

I'm not sure why this is being returned, so this needs some investigation

Steps to reproduce

Run the steps in #851, building the docker image in dan/hive-ci.

The command to run eth_createAccessList tests:

./hive --client reth --sim ethereum/rpc-compat --sim.limit "/eth_createAccessList"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@Rjected Rjected added C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong A-rpc Related to the RPC implementation labels Mar 15, 2023
@Rjected
Copy link
Member Author

Rjected commented Mar 30, 2023

whoops, did not check this before approving, seems like this did not get fixed in #2028, eth_createAccessList tests still return max fee per gas less than block base fee.

maybe we should use the new feature in bluealloy/revm#436 to properly fix this

@mattsse
Copy link
Collaborator

mattsse commented Mar 30, 2023

sg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong
Projects
Archived in project
2 participants