Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use no_base_fee feature for calling RPCs #2041

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 30, 2023

Uses the revm optional_no_base_fee feature instead of setting the base fee to zero in eth_call, eth_estimateGas, and eth_createAccessList.

Fixes #1783
Fixes #2033

🤖 Generated by Copilot at 866a418

The pull request updates the rpc crate to support the disable_base_fee flag for EIP-1559 transactions in the eth_call and eth_createAccessList RPC methods. This improves the compatibility with the revm crate and the go-ethereum reference implementation.

🤖 Generated by Copilot at 866a418

No base fee for the call of doom
We simulate the fire in the revm
Align the crates with the go-eth logic
We are the masters of EIP-1559

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 195d781 into main Mar 30, 2023
@mattsse mattsse deleted the dan/use-base-fee-feature branch March 30, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants