Database table names are inconsistently singular/plural

[shekhirin]

Describe the feature

Tidy up

reth/crates/storage/db/src/tables/mod.rs

Lines 161 to 187 in 6810cd1

	tables!([
	(CanonicalHeaders, TableType::Table),
	(HeaderTD, TableType::Table),
	(HeaderNumbers, TableType::Table),
	(Headers, TableType::Table),
	(BlockBodyIndices, TableType::Table),
	(BlockOmmers, TableType::Table),
	(BlockWithdrawals, TableType::Table),
	(TransactionBlock, TableType::Table),
	(Transactions, TableType::Table),
	(TxHashNumber, TableType::Table),
	(Receipts, TableType::Table),
	(PlainAccountState, TableType::Table),
	(PlainStorageState, TableType::DupSort),
	(Bytecodes, TableType::Table),
	(AccountHistory, TableType::Table),
	(StorageHistory, TableType::Table),
	(AccountChangeSet, TableType::DupSort),
	(StorageChangeSet, TableType::DupSort),
	(HashedAccount, TableType::Table),
	(HashedStorage, TableType::DupSort),
	(AccountsTrie, TableType::Table),
	(StoragesTrie, TableType::DupSort),
	(TxSenders, TableType::Table),
	(SyncStage, TableType::Table),
	(SyncStageProgress, TableType::Table)
	]);

Additional context

No response

[mattsse]

hehe a tale as old as time

[onbjerg]

related #3464

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[yongkangc]

Is anyone working on this right now? And would this be a suitable first ticket for public to work on since its S-breaking? Looking to take on this ticket to familiarize myself to the codebase and contribute deeper in the future.

[shekhirin]

@ExtremelySunnyYK no one is working on it right now, assigned you! S-breaking for the first ticket is fine, as it'll pass the review as usually and will not be merged until the whole batch of breaking PRs is ready to be released.

[yongkangc]

thank you! for assigning it to me @shekhirin appreciate it, will start working on this at this week.

[shekhirin]

hey @ExtremelySunnyYK, let me know if you're no longer working on this, as someone else could take this good first issue!

[JosepBove]

I could take it if he is inactive

[shekhirin]

@JosepBove sounds good, assigned!

[JosepBove]

Thanks, will work on this tomorrow!

[JosepBove]

Does everyone agree with this names?

 tables!([ 
     (CanonicalHeaders, TableType::Table), 
     (HeaderTD, TableType::Table), 
     (HeaderNumbers, TableType::Table), 
     (Headers, TableType::Table), 
     (BlockBodyIndices, TableType::Table), 
     (BlockOmmers, TableType::Table), 
     (BlockWithdrawals, TableType::Table), 
     (TransactionBlock, TableType::Table), 
     (Transactions, TableType::Table), 
     (TransactionHashNumbers, TableType::Table), 
     (Receipts, TableType::Table), 
     (PlainAccountStates, TableType::Table), 
     (PlainStorageStates, TableType::DupSort), 
     (Bytecodes, TableType::Table), 
     (AccountHistory, TableType::Table), 
     (StorageHistory, TableType::Table), 
     (AccountChangeSets, TableType::DupSort), 
     (StorageChangeSets, TableType::DupSort), 
     (HashedAccounts, TableType::Table), 
     (HashedStorages, TableType::DupSort), 
     (AccountsTries, TableType::Table), 
     (StoragesTries, TableType::DupSort), 
     (TransactionSenders, TableType::Table), 
     (SyncStages, TableType::Table), 
     (SyncStageProgresses, TableType::Table) 
 ]); 

[shekhirin]

@JosepBove IMO:

1. HeaderTD -> HeaderTerminalDifficulties, just to be clear what's TD
2. TransactionBlock -> TransactionBlocks
3. Plain(Account|Storage)States -> Plain(Account|Storage)State, because it contains the latest version of the state and not multiple
4. (Accounts|Storages)Tries -> (Accounts|Storages)Trie, same as state

[JosepBove]

Okay, I will keep this discussion open for today, if no one has anything else to say I will implement the changes

[shekhirin]

@mattsse @onbjerg thoughts?

[JosepBove]

As no comments were made I start the implementation

[DaniPopes]

#6787