-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): rename tables #6787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit abe4e69.
shekhirin
added
C-debt
Refactor of code section that is hard to understand or maintain
A-db
Related to the database
S-breaking
This PR includes a breaking change
labels
Feb 26, 2024
joshieDo
approved these changes
Feb 26, 2024
onbjerg
approved these changes
Feb 26, 2024
mattsse
approved these changes
Feb 26, 2024
emhane
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super clean, very helpful descriptive names. a lot of work though, this is why it's nice to just do proper names from the start.
comments (not caught by rustdocs) seem to check out with new naming, good!
shekhirin
force-pushed
the
alexey/rename-tables
branch
from
February 26, 2024 16:55
3b83999
to
4df5dfb
Compare
emhane
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-db
Related to the database
C-debt
Refactor of code section that is hard to understand or maintain
S-breaking
This PR includes a breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on top of #6062, it had too many conflicts, and it was easier to do a find-and-replace all over again. h/t to @JosepBove for the initial impl.
Tables
reth/crates/storage/db/src/tables/mod.rs
Lines 244 to 375 in f8dd4a1