Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover senders manually if not found in database #3938

Closed
Tracked by #3428
shekhirin opened this issue Jul 26, 2023 · 1 comment · Fixed by #4280
Closed
Tracked by #3428

Recover senders manually if not found in database #3938

shekhirin opened this issue Jul 26, 2023 · 1 comment · Fixed by #4280
Labels
A-db Related to the database A-pruning Related to pruning or full node M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Jul 26, 2023

With SenderRecovery prune part enabled, this

let senders =
self.get_or_take::<tables::TxSenders, TAKE>(first_transaction..=last_transaction)?;
will be incorrect, as not all senders are in database anymore, so we need to recover them on-demand.

Also see

// TODO(alexey): removing min blocks restriction is possible if we start calculating the senders
// dynamically on blockchain tree unwind.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 10, 2023
@shekhirin shekhirin added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Aug 10, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database A-pruning Related to pruning or full node M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
1 participant