Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): remove constraints on SenderRecovery pruning #4488

Merged
merged 3 commits into from
Sep 5, 2023
Merged

feat(primitives): remove constraints on SenderRecovery pruning #4488

merged 3 commits into from
Sep 5, 2023

Conversation

shekhirin
Copy link
Collaborator

Possible after #3938

@shekhirin shekhirin added C-enhancement New feature or request A-pruning Related to pruning or full node labels Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #4488 (c1591e4) into main (3e7e651) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/pruning_args.rs 21.42% <0.00%> (ø)
crates/primitives/src/prune/target.rs 63.63% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.65% <0.00%> (+0.01%) ⬆️
unit-tests 63.83% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <0.00%> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.04% <ø> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 48.09% <ø> (-0.03%) ⬇️
networking 77.43% <ø> (-0.04%) ⬇️
rpc 57.40% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.13% <ø> (-0.02%) ⬇️

@shekhirin shekhirin added the M-changelog This change should be included in the changelog label Sep 5, 2023
@shekhirin shekhirin added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 01d4933 Sep 5, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/prune-mode-sender-recovery-no-limit branch September 5, 2023 17:49
Rjected pushed a commit that referenced this pull request Sep 6, 2023
@shekhirin @Rjected
feat(primitives): remove constraints on SenderRecovery pruning (#4488)
7db6ebb
This was referenced Jan 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@gakonst gakonst Awaiting requested review from gakonst

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-pruning Related to pruning or full node C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @joshieDo