Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate primitives imports to reth-primitives #4714

Closed
Tracked by #4715
DaniPopes opened this issue Sep 21, 2023 · 7 comments
Closed
Tracked by #4715

Consolidate primitives imports to reth-primitives #4714

DaniPopes opened this issue Sep 21, 2023 · 7 comments
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 21, 2023 •
edited
Loading

⚠️ Base on #4737 (alloy) ⚠️

Currently we use reth-primitives, revm-primitives/revm::primitives, reth-revm-primitives, and ethers-core interchangeably for primitives types / utils. This might change in the future and they should all be replaced with reth-primitives.
@DaniPopes DaniPopes added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 21, 2023
@tcoratger
Copy link
Contributor

@DaniPopes @mattsse Maybe to start with that we can first migrate the revm-primitives folder of the revm crate directly inside the primitives crates so that everything related to reth-revm-primitives will now be part of reth-primitives, what do you think?

@DaniPopes
Copy link
Member Author

DaniPopes commented Sep 22, 2023 •
edited
Loading

Yeah I think that's doable.

We can also remove all compat hacks between reth and revm since they use the same types:

image

@mattsse
Copy link
Collaborator

mattsse commented Sep 22, 2023

sgtm

@DaniPopes DaniPopes mentioned this issue Sep 23, 2023
Closed
@DaniPopes DaniPopes added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Sep 25, 2023
@duguorong009
Copy link
Contributor

duguorong009 commented Sep 27, 2023 •
edited
Loading

@tcoratger @DaniPopes
Is there anyone working on this issue?
If not, I would like to pick up.

BTW, what should be the base branch of this issue? alloy or main?

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 19, 2023
@tcoratger tcoratger mentioned this issue Oct 19, 2023
Merged
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 27, 2023
@DaniPopes DaniPopes added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 27, 2023
@DaniPopes DaniPopes reopened this Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Oct 27, 2023
@supernovahs
Copy link
Contributor

What's next for this? I can do it.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattsse @DaniPopes @tcoratger @duguorong009 @supernovahs