Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Ethers -> Alloy transition #4715

Closed
15 tasks done
DaniPopes opened this issue Sep 21, 2023 · 4 comments · Fixed by #7508
Closed
15 tasks done

Tracking: Ethers -> Alloy transition #4715

DaniPopes opened this issue Sep 21, 2023 · 4 comments · Fixed by #7508
Labels
C-enhancement New feature or request C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 21, 2023

Main transition

Alloy transition

  1. C-enhancement
    DaniPopes
  2. C-enhancement
    DaniPopes
  3. C-enhancement
    DaniPopes

Ethers removal

Note that only ethers-core is used in Reth code, while other crates are used only for testing which is fine for now.

ethers-core

reth-primitives

  1. C-enhancement D-good-first-issue
    alessandromazza98
  2. C-enhancement D-good-first-issue
    alessandromazza98
  3. C-enhancement D-good-first-issue
    tcoratger
  4. C-enhancement D-good-first-issue
    supernovahs
  5. C-enhancement D-good-first-issue
    supernovahs

reth-rpc

  1. C-enhancement D-good-first-issue
    supernovahs

Rest of Ethers, used in tests

Ethers in tests

Further work

Parity removal

  1. A-dependencies C-enhancement S-stale
  2. A-dependencies C-enhancement
    rkrasiuk

Refactors, upstreaming

  1. C-enhancement D-good-first-issue M-prevent-stale
  2. C-discussion C-enhancement D-complex M-prevent-stale S-feedback-wanted S-needs-design
  3. C-enhancement M-prevent-stale
@DaniPopes DaniPopes added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 21, 2023
@joshieDo joshieDo added C-tracking-issue An issue that collects information about a broad development initiative and removed S-needs-triage This issue needs to be labelled labels Sep 21, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 19, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 27, 2023
@DaniPopes DaniPopes added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 27, 2023
@DaniPopes DaniPopes reopened this Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Oct 27, 2023
@gakonst
Copy link
Member

gakonst commented Jan 12, 2024

Do we have all the necessary alloy network implementations now? I think so? cc @Evalir @DaniPopes

@DaniPopes
Copy link
Member Author

I've looked at the tests a few days ago. They use an extension to SignerMiddleware with some RPC calls I believe we don't have yet, and the geth wrapper GethInstance to spawn a geth process:

pub struct CliqueGethInstance {

This would also unblock #6006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants