Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate H* type re-exports, and rename to B* in the codebase #4740

Closed
Tracked by #4715
DaniPopes opened this issue Sep 23, 2023 · 3 comments
Closed
Tracked by #4715

Deprecate H* type re-exports, and rename to B* in the codebase #4740

DaniPopes opened this issue Sep 23, 2023 · 3 comments
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 23, 2023

⚠️ Base on #4737 (alloy) ⚠️

(Referring to H64, H256...)

  • Remove H* types re-export; this means also renaming the types in the entire codebase:
- pub use alloy_primitives::{... BXXX as HXXX ...};
+ pub use alloy_primitives::{... BXXX ...};
  • Re-add H* types with a hidden, deprecated type alias for backwards compatibility:
#[doc(hidden)]
#[deprecated = "use BXXX instead"]
pub type HXXX = BXXX;

Note: you might want to wait until the rest of #4715 is done to avoid conflicts

@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Sep 23, 2023
@supernovahs
Copy link
Contributor

Can I take this

@supernovahs
Copy link
Contributor

Should I push in accordance with alloy branch?

@DaniPopes
Copy link
Member Author

Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

2 participants