Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on rlp #4796

Closed
Tracked by #4715
DaniPopes opened this issue Sep 26, 2023 · 3 comments
Closed
Tracked by #4715

Remove dependency on rlp #4796

DaniPopes opened this issue Sep 26, 2023 · 3 comments
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 26, 2023

rlp is used by:

$ cargo tree -i rlp --depth 2
rlp v0.5.2
├── discv5 v0.3.1 (https://github.com/sigp/discv5?rev=d2e30e04ee62418b9e57278cee907c02b99d5bd1#d2e30e04)
│   └── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4)
├── enr v0.9.1
│   ├── discv5 v0.3.1 (https://github.com/sigp/discv5?rev=d2e30e04ee62418b9e57278cee907c02b99d5bd1#d2e30e04) (*)
│   ├── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4) (*)
│   └── reth-dns-discovery v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/dns)
├── ethers-core v2.0.10
│   ├── reth-eth-wire v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/eth-wire)
│   ├── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives)
│   └── reth-rpc v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/rpc/rpc)
├── impl-rlp v0.3.0
│   ├── ethbloom v0.13.0
│   ├── ethereum-types v0.14.1
│   └── primitive-types v0.12.1
├── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4) (*)
└── triehash v0.8.4
    └── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives) (*)

Triehash: #4797

Internally, only used by reth-discv4 in EnrWrapper.

@DaniPopes DaniPopes added C-enhancement New feature or request A-dependencies Pull requests or issues that are about dependencies labels Sep 26, 2023
@mattsse
Copy link
Collaborator

mattsse commented Oct 12, 2023

this is tough, because we need this to decode Enr which can only be decoded via rlp -.- the only workaround would be to use the EnrBuilder type, but this would be pointless since the enr crate already pulls in the rlp crate, so we can reuse it for free

Copy link
Contributor

github-actions bot commented Nov 3, 2023

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Nov 3, 2023
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

2 participants