Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ethers conversions (mod ethers_compat etc) in reth-primitives #4738

Closed
Tracked by #4715
DaniPopes opened this issue Sep 23, 2023 · 4 comments · Fixed by #4771
Closed
Tracked by #4715

Remove ethers conversions (mod ethers_compat etc) in reth-primitives #4738

DaniPopes opened this issue Sep 23, 2023 · 4 comments · Fixed by #4771
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 23, 2023

⚠️ Base on #4737 (alloy) ⚠️

Goal: get rid of ethers-core in reth-primitives as much as possible

@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Sep 23, 2023
@tcoratger
Copy link
Contributor

@DaniPopes What do you have in mind here except ethers_compat? I would say that ethers_compat can be removed now and then we wait for #4737 and we open a separate issue for:

  • FromHex
  • Chain types

that are also related to conversion but can be converted into separate issues to avoid too big changes and confusion, what do you think?

@DaniPopes
Copy link
Member Author

DaniPopes commented Sep 25, 2023

I guess just ethers_compat looking at it, I named this issue before splitting it in the task list in the tracking issue. I don't know what you mean by FromHex, and Chain is tracked in #4741. What related conversion do you mean?

@tcoratger
Copy link
Contributor

I guess just ethers_compat looking at it, I named this issue before splitting it in the task list in the tracking issue. I don't know what you mean by FromHex, and Chain is tracked in #4741. What related conversion do you mean?

@DaniPopes Here:

use ethers_core::utils::hex::{self, FromHex};

I imagine that if we want to completely eliminate ethers-core from the primitives crate we will also have to remove this dependency to switch to alloy, right? Or did I miss something?

@DaniPopes
Copy link
Member Author

Already gone on alloy:

mod tests {
use super::{Bytes, Decodable, Encodable, Header, H256};
use crate::{address, b256, bloom, bytes, hex, Address, HeadersDirection, U256};
use std::str::FromStr;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants