Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use alloy_primitives in rpc-types #5075

Closed
mattsse opened this issue Oct 18, 2023 · 0 comments · Fixed by #5078
Closed

use alloy_primitives in rpc-types #5075

mattsse opened this issue Oct 18, 2023 · 0 comments · Fixed by #5078
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 18, 2023 •
edited
Loading

Describe the feature

currently we're using the reexported primitives, B256, U*, Address from reth_primitives, which are just reexports from alloy_primitives.

TODO

repace all reth_primitives::B256,U*,Address with alloy_primitives

assigning @DoTheBestToGetTheBest

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 18, 2023
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Oct 18, 2023
@tcoratger tcoratger mentioned this issue Oct 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rpc): use alloy_primitives in rpc-types tcoratger/reth
1 participant
@mattsse