Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): use alloy_primitives in rpc-types #5078

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

tcoratger
Copy link
Contributor

Should close #5075.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5078 (e2805a0) into main (05044c1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-types/src/admin.rs 96.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/account.rs 85.18% <ø> (ø)
crates/rpc/rpc-types/src/eth/block.rs 65.98% <ø> (ø)
crates/rpc/rpc-types/src/eth/call.rs 56.56% <ø> (ø)
crates/rpc/rpc-types/src/eth/engine/cancun.rs 0.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/engine/forkchoice.rs 34.09% <ø> (ø)
crates/rpc/rpc-types/src/eth/engine/payload.rs 79.69% <ø> (ø)
crates/rpc/rpc-types/src/eth/engine/transition.rs 100.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/fee.rs 9.09% <ø> (ø)
crates/rpc/rpc-types/src/eth/filter.rs 77.79% <ø> (ø)
... and 21 more

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.06% <ø> (-0.01%) ⬇️
unit-tests 62.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.90% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.38% <ø> (ø)
storage (db) 74.64% <ø> (ø)
trie 94.96% <ø> (ø)
txpool 55.76% <ø> (+0.43%) ⬆️
networking 78.20% <ø> (-0.18%) ⬇️
rpc 58.31% <ø> (ø)
consensus 63.01% <ø> (ø)
revm 28.73% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 86.41% <ø> (-0.04%) ⬇️

@gakonst
Copy link
Member

gakonst commented Oct 18, 2023

@mattsse is the motivation for this that it will make the copy-pasting of the RPC types into alloy-rpc faster/easier?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Collaborator

mattsse commented Oct 18, 2023

@mattsse is the motivation for this that it will make the copy-pasting of the RPC types into alloy-rpc faster/easier?

yes

@mattsse mattsse added this pull request to the merge queue Oct 18, 2023
@mattsse mattsse added the A-rpc Related to the RPC implementation label Oct 18, 2023
Merged via the queue into paradigmxyz:main with commit c17c3cd Oct 18, 2023
24 checks passed
@tcoratger tcoratger deleted the reth_primitives branch October 19, 2023 07:40
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use alloy_primitives in rpc-types
3 participants