Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust version #5965

Closed
supernovahs opened this issue Jan 6, 2024 · 1 comment · Fixed by #5974
Closed

Update rust version #5965

supernovahs opened this issue Jan 6, 2024 · 1 comment · Fixed by #5974
Labels
C-enhancement New feature or request

Comments

@supernovahs
Copy link
Contributor

Describe the feature

Current rust version in reth is 1.70

Maybe we should update it incrementally by looking at changes for each release in rust lang

Wdyt?

Additional context

No response
@supernovahs supernovahs added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 6, 2024
Rjected added a commit that referenced this issue Jan 8, 2024
@Rjected
chore: update MSRV to 1.75
bd7b43d 
We use features in code from 1.72, and `[lints]` is from 1.75, so we
should update MSRV to 1.75

closes #5965
@Rjected Rjected mentioned this issue Jan 8, 2024
Merged
@Rjected
Copy link
Member

Rjected commented Jan 8, 2024

The rust-version field in Cargo.toml represents the minimum supported rust version, so this should only be updated when we adopt features in newer rust versions. We did adopt features newer than 1.70 though, so updated it here: #5974

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 8, 2024
@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update MSRV to 1.75 paradigmxyz/reth
3 participants
@Rjected @DaniPopes @supernovahs