Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotProvider should be Arc<SnapshotProviderInner> #6249

Closed
joshieDo opened this issue Jan 26, 2024 · 1 comment
Closed

SnapshotProvider should be Arc<SnapshotProviderInner> #6249

joshieDo opened this issue Jan 26, 2024 · 1 comment
Labels
A-static-files Related to static files C-enhancement New feature or request

Comments

@joshieDo
Copy link
Collaborator

Originally posted by @joshieDo in #6103 (comment)

It was further to rename SnapshotProvider to SnapshotProviderInner and redefine SnapshotProvideras an Arc<SnapshotProviderInner>, since the usage of SnapshotProvider is always accompanied by an Arc over it.
@joshieDo joshieDo added A-static-files Related to static files C-enhancement New feature or request labels Jan 26, 2024
@tcoratger tcoratger mentioned this issue Jan 26, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Feb 17, 2024
@joshieDo joshieDo removed the S-stale This issue/PR is stale and will close with no further activity label Feb 18, 2024
@joshieDo joshieDo mentioned this issue Feb 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-static-files Related to static files C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add SnapshotProvider to encapsulate Arc<SnapshotProviderInner> tcoratger/reth
1 participant
@joshieDo