feat: adds parallelization to SenderRecovery and TxLookup using SnapshotProvider
#6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
requested review from
rakita,
onbjerg,
rkrasiuk,
shekhirin and
gakonst
as code owners
joshieDo
added
A-staged-sync
mattsse
requested changes
Feb 18, 2024
Comment on lines
+43
to
+44
| #[derive(Debug, Default, Clone)] | ||
| pub struct SnapshotProvider(Arc<SnapshotProviderInner>); |
There was a problem hiding this comment.
cool, this now closes the other pr that adds this main
Comment on lines
+99
to
+101
| pub fn with_filters(self) -> Self { | ||
| let mut provider = | ||
| Arc::try_unwrap(self.0).expect("should be called when initializing only."); |
There was a problem hiding this comment.
for followup, this should be called during SnapshotProvider::new
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
shekhirin
force-pushed
the
feat/static-files
branch
6 times, most recently
from
d75d4e3
to
043f07d
Compare
shekhirin
approved these changes
Feb 20, 2024
| @@ -194,18 +194,26 @@ impl TestStageDB { | |||
| /// Insert ordered collection of [SealedBlock] into corresponding tables. | |||
| /// Superset functionality of [TestStageDB::insert_headers]. | |||
| /// | |||
| /// If tx_offset is set to `None`, then transactions will be stored on static files, otherwise | |||
There was a problem hiding this comment.
oof imo it's easy to misuse. Maybe an explicit enum?
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
shekhirin
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SnapshotProvidershould beArc<SnapshotProviderInner>#6249transaction_hashes_by_rangeon static files parallel: each rayon worker reads the file(and deserializes) on their own vs mdbx where reading and deserialization is done on the main thread before sending it to rayon workers for hashing.chunk_sizeon parallelization is set to100: Kinda arbitrary. The way it was before it was too high and there were a bunch of rayon threads waiting for work. (image comparison incoming)Benches
holesky
maxperf@ block 925555TransactionLookupwent from [57s-59s] to [47s-50s].SenderRecoverydidn't benefit from static files (heavily cpu bound), but thechunk_sizereduction helped it go from 49s to 44s.