Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add op-reth basic debug.tip sync test in CI #9057

Closed
Rjected opened this issue Jun 24, 2024 · 2 comments · Fixed by #9062
Closed

Add op-reth basic debug.tip sync test in CI #9057

Rjected opened this issue Jun 24, 2024 · 2 comments · Fixed by #9062
Labels
A-ci Related to github workflows or other build and lint tools A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test

Comments

@Rjected
Copy link
Member

Rjected commented Jun 24, 2024

We currently have the following test in CI for mainnet, which ensures that we can sync a small number of blocks:

sync:
name: sync / 100k blocks
# Only run sync tests in merge groups
if: github.event_name == 'merge_group'
runs-on:
group: Reth
env:
RUST_LOG: info,sync=error
RUST_BACKTRACE: 1
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- name: Run sync
run: |
cargo run --release --features asm-keccak,jemalloc,min-error-logs --bin reth \
-- node \
--debug.tip 0x91c90676cab257a59cd956d7cb0bceb9b1a71d79755c23c7277a0697ccfaf8c4 \
--debug.max-block 100000 \
--debug.terminate
- name: Verify the target block hash
run: |
cargo run --release --bin reth \
-- db get static-file headers 100000 \
| grep 0x91c90676cab257a59cd956d7cb0bceb9b1a71d79755c23c7277a0697ccfaf8c4
- name: Run stage unwind for 100 blocks
run: |
cargo run --release --bin reth \
-- stage unwind num-blocks 100

We should add this for an op-reth binary as well

@Rjected Rjected added C-test A change that impacts how or what we test A-op-reth Related to Optimism and op-reth A-ci Related to github workflows or other build and lint tools labels Jun 24, 2024
@Rjected
Copy link
Member Author

Rjected commented Jun 24, 2024

note: we should probably set the # of blocks to something much lower, like 5000 or 10000

@joshieDo
Copy link
Collaborator

base-mainnet probably would be the ideal choice here as well. No import necessary and i'm guessing with more nodes in the network

Rjected added a commit that referenced this issue Jun 24, 2024
This uses base mainnet and syncs 10k blocks instead of 100k, closes #9057
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Related to github workflows or other build and lint tools A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants