Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATs Network and Task to FullNodeComponents #9872

Closed
emhane opened this issue Jul 29, 2024 · 2 comments
Closed

Add ATs Network and Task to FullNodeComponents #9872

emhane opened this issue Jul 29, 2024 · 2 comments
Labels
A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@emhane
Copy link
Member

emhane commented Jul 29, 2024

Describe the feature

RPC types use generics Network and Tasks, which resolve to the type returned by FullNodeComponents getters.

The two should be added as ATs on FullNodeComponents, to make them possible to reference in type definitions.

/// Returns the handle to the network
fn network(&self) -> &NetworkHandle;
/// Returns the handle to the payload builder service.
fn payload_builder(&self) -> &PayloadBuilderHandle<Self::Engine>;
/// Returns the task executor.
fn task_executor(&self) -> &TaskExecutor;

Additional context

No response

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 20, 2024
@emhane emhane added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Aug 20, 2024
@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

marking this as complete because we don't need a generic for tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

No branches or pull requests

2 participants