Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace unreachable error variant #10049

Merged
merged 1 commit into from
Aug 3, 2024
Merged

chore: replace unreachable error variant #10049

merged 1 commit into from
Aug 3, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 3, 2024

this branch should be unreachable if configured properly.

removes the error variant and replaces it with Other instead

@mattsse mattsse requested review from Rjected and emhane as code owners August 3, 2024 04:39
@mattsse mattsse added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation labels Aug 3, 2024
@emhane emhane added this pull request to the merge queue Aug 3, 2024
Merged via the queue into main with commit c2926de Aug 3, 2024
33 checks passed
@emhane emhane deleted the matt/replace-unreachable-error-variant branch August 3, 2024 13:31
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@mattsse @martinezjorge
chore: replace unreachable error variant (paradigmxyz#10049)
82cdb50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @emhane