Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI lint check using cargo hack for checking features powerset #10142

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add CI lint check using cargo hack for checking features powerset #10142

merged 1 commit into from
Aug 6, 2024

Conversation

citizen-stig
Copy link
Contributor

4th follow up #10130

This PR adds cargo hack to CI, making sure that selected crates also can compile with different combinations of features

@citizen-stig citizen-stig mentioned this pull request Aug 6, 2024
Closed
mattsse
mattsse approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@mattsse mattsse added this pull request to the merge queue Aug 6, 2024
@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Aug 6, 2024
Merged via the queue into paradigmxyz:main with commit 8d07bdb Aug 6, 2024
35 checks passed
@citizen-stig
Copy link
Contributor Author

@mattsse , thank you for taking a look and merging!

Should I do a follow up to make pr like this:

pr:
	make lint && \
	make check-features && \
	make update-book-cli && \
	make test

I suppose this should improve DevEx, but also add some disk usage and compilation times!

martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@citizen-stig @martinezjorge
Add CI lint check using cargo hack for checking features powerset (pa…
84d3031 
…radigmxyz#10142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@citizen-stig @mattsse