Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate executed block into OP built payload #10162

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: integrate executed block into OP built payload #10162

merged 4 commits into from
Aug 7, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 7, 2024

towards #10159

integrates the ExecutedBlock data into OP's built payload

@mattsse mattsse added the C-enhancement New feature or request label Aug 7, 2024
@mattsse mattsse requested a review from rkrasiuk August 7, 2024 12:39
fgimenez
fgimenez approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, small doc nit

crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
mattsse and others added 2 commits August 7, 2024 15:12
@mattsse @fgimenez
Update crates/optimism/payload/src/builder.rs
3872154 
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
@mattsse @fgimenez
Update crates/optimism/payload/src/builder.rs
20b62a5 
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
rkrasiuk
rkrasiuk approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@mattsse mattsse added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 0fb7276 Aug 7, 2024
34 checks passed
@mattsse mattsse deleted the matt/integrate-executed-block-in-op-built-payload branch August 7, 2024 14:25
@mattsse mattsse mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@fgimenez fgimenez fgimenez approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @fgimenez @rkrasiuk