Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add spec docs and todo for OP #10171

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 7, 2024

adds an excerpt from the spec, this is equivalent to legacy engine check

// On Optimism, the proposers are allowed to reorg their own chain at will.
#[cfg(feature = "optimism")]
if self.blockchain.chain_spec().is_optimism() {
debug!(
target: "consensus::engine",
fcu_head_num=?header.number,
current_head_num=?head.number,
"[Optimism] Allowing beacon reorg to old head"
);
return true
}
// 2. Client software MAY skip an update of the forkchoice state and MUST NOT begin a
// payload build process if `forkchoiceState.headBlockHash` references a `VALID` ancestor
// of the head of canonical chain, i.e. the ancestor passed payload validation process
// and deemed `VALID`. In the case of such an event, client software MUST return
// `{payloadStatus: {status: VALID, latestValidHash: forkchoiceState.headBlockHash,
// validationError: null}, payloadId: null}`
if head != &header.num_hash() {
attrs.take();
}

for op we still need to trigger a payload job and perhaps even force canonicalize the head

@mattsse mattsse added the C-docs An addition or correction to our documentation label Aug 7, 2024
@mattsse mattsse added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit aa533da Aug 7, 2024
34 checks passed
@mattsse mattsse deleted the matt/add-docs-and-todo-for-OP branch August 7, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants