Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove #[reth_codec] and #[derive_arbitrary] macros #10263

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Aug 12, 2024

Closes #10238

Removes and replaces reth_codec and derive_arbitrary derive macros with explicit cfg_attr attributes and add_arbitrary_tests invocations

@github-actions github-actions bot added the C-test A change that impacts how or what we test label Aug 12, 2024
@klkvr klkvr changed the title replace #[reth_codec] and #[derive_arbitrary] refactor: remove #[reth_codec] and #[derive_arbitrary] macros Aug 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this is so much better!

@mattsse mattsse added this pull request to the merge queue Aug 12, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 12, 2024
Merged via the queue into main with commit 330f73b Aug 12, 2024
34 checks passed
@mattsse mattsse deleted the klkvr/tests-derive branch August 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract test generation from derive macros
2 participants