Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: rm confy as a dep #10290

Merged
merged 12 commits into from
Aug 20, 2024
Merged

dep: rm confy as a dep #10290

merged 12 commits into from
Aug 20, 2024

Conversation

tcoratger
Copy link
Contributor

Related #7889

@shekhirin shekhirin added the A-dependencies Pull requests or issues that are about dependencies label Aug 15, 2024
shekhirin
shekhirin requested changes Aug 15, 2024
View reviewed changes
crates/cli/commands/src/common.rs Outdated Show resolved Hide resolved
crates/cli/commands/src/common.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/node/builder/src/launch/common.rs Outdated Show resolved Hide resolved
tcoratger and others added 2 commits August 14, 2024 19:27
@tcoratger @shekhirin
Update crates/cli/commands/src/common.rs
325334a 
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
@tcoratger
fix comments
afe2ba9
onbjerg
onbjerg requested changes Aug 17, 2024
View reviewed changes
crates/cli/commands/src/p2p/mod.rs Outdated Show resolved Hide resolved
crates/node/builder/src/launch/common.rs Outdated Show resolved Hide resolved
shekhirin
shekhirin previously requested changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

crates/cli/commands/src/config_cmd.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure this is equivalent because confy_load also stores a default instance in the file if it does not exist.

we should check that the reth.toml is created we launch the node

tcoratger
tcoratger commented Aug 17, 2024
View reviewed changes
crates/config/Cargo.toml Outdated Show resolved Hide resolved
@tcoratger
Copy link
Contributor Author

not 100% sure this is equivalent because confy_load also stores a default instance in the file if it does not exist.

we should check that the reth.toml is created we launch the node

@mattsse I just used a slightly different approach, tell me what you think. I saw that the load was only used in the code to generate an instance of Config. So I wrote in Config a function from_path that takes a little bit of what is in confy while simplifying it to keep what interests us only.

I added unit tests to cover the different cases including the one you mentioned where the directory does not exist and is then created.

onbjerg
onbjerg approved these changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty for this

mattsse
mattsse approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mattsse mattsse added this pull request to the merge queue Aug 20, 2024
Merged via the queue into paradigmxyz:main with commit cd05a96 Aug 20, 2024
35 checks passed
fgimenez pushed a commit that referenced this pull request Aug 20, 2024
@tcoratger @shekhirin @fgimenez
dep: rm confy as a dep (#10290)
44e848d 
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
@onbjerg onbjerg mentioned this pull request Oct 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin shekhirin left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoratger @shekhirin @onbjerg @mattsse