Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): range methods in BlockchainProvider2 #10300

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix(provider): range methods in BlockchainProvider2 #10300

merged 1 commit into from
Aug 14, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 14, 2024 •
edited
Loading

Fixes #10297

We should also probably introduce a helper function for querying both database and in-memory state by range.

@github-actions github-actions bot added A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior labels Aug 14, 2024
@shekhirin shekhirin marked this pull request as ready for review August 14, 2024 17:55
DaniPopes
DaniPopes approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, advance_by use case but it's unstable

mattsse
mattsse approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should do it

@mattsse mattsse added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 4421565 Aug 14, 2024
35 checks passed
@mattsse mattsse deleted the alexey/blockchain-provider-range-fix branch August 14, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockchainProvider2 range methods do not fetch in-memory blocks
4 participants
@shekhirin @onbjerg @mattsse @DaniPopes