reth book: add instruction to update rust version #10308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap2pecs
changed the title
mattsse
approved these changes
Aug 14, 2024
| @@ -32,6 +32,9 @@ operating system: | |||
|
|
|||
| These are needed to build bindings for Reth's database. | |||
|
|
|||
| The Minimum Supported Rust Version (MSRV) of this project is 1.80.0. If you already have a version of Rust installed, | |||
There was a problem hiding this comment.
making mental note that we always need to update this as well when we bump msrv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the book to build reth, but I got error
then I found the GH README mentioned "The Minimum Supported Rust Version (MSRV) of this project is 1.80.0." but this is not in the book.
So I am adding it to the book to keep consistent. Also add the instructions for checking and updating rust version
Note: the trouble shooting section briefly mentioned if there is compile error, you can upgrade rust. but I think it's better to avoid such error in the first place.