Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(net): expose max concurrent GetPooledTransactions reqs in cli #10358

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 15, 2024

Exposes GetPooledTransactions requests concurrency parameters in cli

@emhane emhane added A-networking Related to networking in general A-cli Related to the reth CLI labels Aug 15, 2024
@emhane emhane force-pushed the emhane/tx-reqs-concurrency-cli-arg branch from e6aeb9c to 96e0a8b Compare August 15, 2024 23:34
@emhane emhane added the C-debt Refactor of code section that is hard to understand or maintain label Aug 15, 2024
@emhane emhane force-pushed the emhane/tx-reqs-concurrency-cli-arg branch from 7f39bf7 to b86e923 Compare August 16, 2024 00:33
@emhane emhane changed the title chore(net): expose max concurrent GetPooledTransactions reqs per peer in cli chore(net): expose max concurrent GetPooledTransactions reqs in cli Aug 16, 2024
@rkrasiuk
Copy link
Member

@emhane semicolons ... please 🙏

@emhane emhane force-pushed the emhane/tx-reqs-concurrency-cli-arg branch from cc8b78a to c23c67a Compare August 17, 2024 22:41
@emhane emhane force-pushed the emhane/tx-reqs-concurrency-cli-arg branch from 0d51d10 to 2a91a56 Compare August 17, 2024 22:45
@emhane emhane enabled auto-merge August 17, 2024 22:51
@emhane emhane force-pushed the emhane/tx-reqs-concurrency-cli-arg branch from 0dd580c to 94ab23b Compare August 17, 2024 22:56
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something went wrong here

perhaps it's easier to close this and reopen again

@emhane
Copy link
Member Author

emhane commented Aug 21, 2024

something went wrong here

perhaps it's easier to close this and reopen again

you need to be more specific for me to follow. what went wrong?

auto-merge was automatically disabled August 21, 2024 13:45

Pull Request is not mergeable

@emhane emhane requested a review from mattsse August 21, 2024 15:07
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I reviewed this, this had a changeset of 2k slocs

but looks this was just a rebasing issue

@emhane emhane added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 1581010 Aug 22, 2024
34 checks passed
@emhane emhane deleted the emhane/tx-reqs-concurrency-cli-arg branch August 22, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants