feat(rpc): get_account #10369
Merged
feat(rpc): get_account #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
rkrasiuk,
Rjected,
mattsse and
emhane
as code owners
|
I couldn't find a place to add tests to this, I can add in another PR if this is something we would want. |
rkrasiuk
requested changes
Aug 17, 2024
rkrasiuk
added
C-enhancement
rkrasiuk
reviewed
Aug 19, 2024
rkrasiuk
requested changes
Aug 19, 2024
| .unwrap_or_default(); | ||
| let balance = account.balance; | ||
| let nonce = account.nonce; | ||
| let code_hash = account.bytecode_hash.unwrap_or_default(); |
There was a problem hiding this comment.
actually, if None this will be 0x000 whereas it should be KECCAK_EMPTY
There was a problem hiding this comment.
of course sorry for missing this
greged93
force-pushed
the
feat/get-account
branch
from
0435b5c
to
64d4ef1
Compare
greged93
force-pushed
the
feat/get-account
branch
from
64d4ef1
to
b691d99
Compare
gakonst
reviewed
Aug 19, 2024
Comment on lines
+149
to
+153
| // Provide a default `HashedStorage` value in order to | ||
| // get the storage root hash of the current state. | ||
| let storage_root = state | ||
| .hashed_storage_root(address, Default::default()) | ||
| .map_err(Self::Error::from_eth_err)?; |
There was a problem hiding this comment.
isn't this always the same? can it be const?
There was a problem hiding this comment.
I'm not sure what you mean, which part could be a const?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the rpc endpoint
get_accountand solves #9625.Makes use of the
hashed_storage_rootmethod from theStateRootProviderand passes an emptyHashedStoragein order to only get the storage root of the current state for the provided account.