Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: BlockReaderIdExt implementation for BlockchainProvider2 #10376

Merged
merged 12 commits into from
Aug 20, 2024
Merged

test: BlockReaderIdExt implementation for BlockchainProvider2 #10376

merged 12 commits into from
Aug 20, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Aug 17, 2024 •
edited by shekhirin
Loading

Add tests for the BlockReaderIdExt and closes #10351.

@greged93 greged93 marked this pull request as draft August 17, 2024 18:19
@greged93 greged93 force-pushed the test/BlockReaderIdExt branch 2 times, most recently from c0bd213 to 8c460eb Compare August 17, 2024 20:26
@greged93 greged93 marked this pull request as ready for review August 17, 2024 20:27
@greged93 greged93 changed the title test(bp2): BlockReaderIdExt test: BlockReaderIdExt implementation for BlockchainProvider2 Aug 17, 2024
@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 19, 2024
shekhirin
shekhirin requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests LGTM, only comments regarding the new helper function

crates/storage/provider/src/providers/blockchain_provider.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/blockchain_provider.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin mentioned this pull request Aug 20, 2024
Merged
@shekhirin shekhirin added this pull request to the merge queue Aug 20, 2024
Merged via the queue into paradigmxyz:main with commit 9c71fa8 Aug 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test BlockReaderIdExt implementation of BlockchainProvider2<DB>
2 participants
@greged93 @shekhirin