Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exex: add unit tests for exex manager #10380

Merged
merged 12 commits into from
Aug 20, 2024
Merged

exex: add unit tests for exex manager #10380

merged 12 commits into from
Aug 20, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #8692

shekhirin
shekhirin requested changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, we didn't have any tests for the ExExManager for a while. Left some comments and suggestions.

crates/exex/exex/src/manager.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/manager.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/manager.rs Show resolved Hide resolved
crates/exex/exex/src/manager.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/manager.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin added C-test A change that impacts how or what we test A-exex Execution Extensions labels Aug 19, 2024
onbjerg
onbjerg approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty for this

@onbjerg onbjerg requested a review from shekhirin August 20, 2024 05:03
shekhirin
shekhirin approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shekhirin shekhirin added this pull request to the merge queue Aug 20, 2024
Merged via the queue into paradigmxyz:main with commit 32fb613 Aug 20, 2024
34 checks passed
fgimenez pushed a commit that referenced this pull request Aug 20, 2024
@tcoratger @fgimenez
exex: add unit tests for exex manager (#10380)
f1899c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@shekhirin shekhirin shekhirin approved these changes

Assignees
No one assigned
Labels
A-exex Execution Extensions C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exex manager test coverage
3 participants
@tcoratger @shekhirin @onbjerg